Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to add acl on list of necessary package #8639

Merged
merged 4 commits into from
May 12, 2018
Merged

Update to add acl on list of necessary package #8639

merged 4 commits into from
May 12, 2018

Conversation

Cormoran96
Copy link
Contributor

@Cormoran96 Cormoran96 commented Apr 30, 2018

Add acl package for the installation of Librenms

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Add acl package for the installation of Librenms
@murrant
Copy link
Member

murrant commented Apr 30, 2018

Thanks can you update the nginx install too and keep the package list alphabetical (put acl first)

@CLAassistant
Copy link

CLAassistant commented May 1, 2018

CLA assistant check
All committers have signed the CLA.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@Cormoran96
Copy link
Contributor Author

I added !

murrant
murrant previously approved these changes May 2, 2018
@murrant
Copy link
Member

murrant commented May 2, 2018

@Cormoran96 I just checked and acl is installed by the base system in Ubuntu 16.04. Why do we need to add it?

@Cormoran96
Copy link
Contributor Author

I just check on minimal install.

laf
laf previously approved these changes May 8, 2018
Copy link
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murrant murrant merged commit 182185d into librenms:master May 12, 2018
TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018
* Update to add acl on list of necessary package

Add acl package for the installation of Librenms

* Change sort

add acl to first

* Change file to add acl package
@Cormoran96 Cormoran96 deleted the patch-1 branch May 28, 2018 18:21
@Cormoran96 Cormoran96 restored the patch-1 branch May 28, 2018 18:21
mattie47 pushed a commit to mattie47/librenms that referenced this pull request Jul 2, 2018
* Update to add acl on list of necessary package

Add acl package for the installation of Librenms

* Change sort

add acl to first

* Change file to add acl package
@lock lock bot locked as resolved and limited conversation to collaborators Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants