New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to add acl on list of necessary package #8639

Merged
merged 4 commits into from May 12, 2018

Conversation

Projects
None yet
6 participants
@Cormoran96
Contributor

Cormoran96 commented Apr 30, 2018

Add acl package for the installation of Librenms

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Update to add acl on list of necessary package
Add acl package for the installation of Librenms
@murrant

This comment has been minimized.

Member

murrant commented Apr 30, 2018

Thanks can you update the nginx install too and keep the package list alphabetical (put acl first)

Cormoran96 added some commits Apr 30, 2018

Change sort
add acl to first
@CLAassistant

This comment has been minimized.

CLAassistant commented May 1, 2018

CLA assistant check
All committers have signed the CLA.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented May 1, 2018

The inspection completed: No new issues

@Cormoran96

This comment has been minimized.

Contributor

Cormoran96 commented May 1, 2018

I added !

@murrant

This comment has been minimized.

Member

murrant commented May 2, 2018

@Cormoran96 I just checked and acl is installed by the base system in Ubuntu 16.04. Why do we need to add it?

@murrant murrant dismissed their stale review May 2, 2018

ignore

@Cormoran96

This comment has been minimized.

Contributor

Cormoran96 commented May 2, 2018

I just check on minimal install.

@laf

laf approved these changes May 10, 2018

LGTM

@murrant murrant merged commit 182185d into librenms:master May 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Update to add acl on list of necessary package (librenms#8639)
* Update to add acl on list of necessary package

Add acl package for the installation of Librenms

* Change sort

add acl to first

* Change file to add acl package

@Cormoran96 Cormoran96 deleted the Cormoran96:patch-1 branch May 28, 2018

@Cormoran96 Cormoran96 restored the Cormoran96:patch-1 branch May 28, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Update to add acl on list of necessary package (librenms#8639)
* Update to add acl on list of necessary package

Add acl package for the installation of Librenms

* Change sort

add acl to first

* Change file to add acl package

@lock lock bot locked as resolved and limited conversation to collaborators Jul 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.