New OS: Support for Glass Way EYDFA WDM Optical Amplifier

[TheGreatDoc]

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

• Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

NOTE: Those devices come all with same sysName so $config['allow_duplicate_sysName'] = true; is needed to have more than 1 working.

[TheGreatDoc]

Im stucked here. Dont know why Travis complains about sensors, i've not changed them, only did formattings fixes.

[laf]

Change the mib dir to glassway

[TheGreatDoc]

I'll do! 👌

[laf]

Do you not have the OID names to use here? Also needs converting to multi gets.

[TheGreatDoc]

Yes. I dont know why I used numeric.

[laf]

I'll give this a shot to move to yml.

[TheGreatDoc]

I can try again with yml, but I'll need some help in how to select proper values for te table that contains different sensor types (Current and Voltage) and in the parse of the limits indexes (yml parse part of the oid as index)

[TheGreatDoc]

@laf I moved to yaml. The only I cant get working are the limits.

Yaml: https://pastebin.com/EXbNyE5y
Discovery Debug: https://pastebin.com/1dz4kcer

[laf]

You need to pre-cache analogPropertyTable to access the hi-low of analogAlarmLOLO, etc. (see includes/definitions/discovery/routeros.yaml) for an example.

[TheGreatDoc]

Still stucked, even with pre-cache.

I've tried using:

low_limit: '{{ $analogAlarmLOLO }}'
and
high_limit: '{{ $analogAlarmHIHI.11.1.3.6.1.4.1.17409.1.11.2.0 }}'

With same result. No limit is set in the discovery

[laf]

You'll need to post the updated files and discovery debug :)

[TheGreatDoc]

Sometimes I'm like a newbie.
Disco debug: https://p.libren.ms/view/899379bf
Yaml: https://p.libren.ms/view/e0a73ad5

[laf]

Last little bit then this is good to go

[laf]

Sorry I think one last thing, the $sensor_index values look too random. You should use for instance commonDeviceInternalTemperature.$index

[TheGreatDoc]

I was using the sensor description as sensor index, so the code is the same in all sensors but I dont really care on the name of sensor index.
I've also change the $value inserted in discovery to be divided by $divisor. Before, in discovery, values were inserted without it, making them wrong until poller.

[CLAassistant]

All committers have signed the CLA.

[laf]

Hopefully the svg was just the last thing that needed fixing. You can use https://jakearchibald.github.io/svgomg/ to compress the file + you need to swap out width/height for a viewbox value - see existing files.

I've sorted this now so hopefully tests pass.

[TheGreatDoc]

Thanks @laf
I was looking how to remove those attributes and found nothing...
Now travis complains about the yaml. It must be kidding us....

[laf]

LGTM