WebUI: edituser page with new Auth system #9313
Conversation
|
Definitely something that is needed. If you are up to it, you might as well refactor it to a Laravel page. Put an route in web.php, create a controller and make a blade template. |
|
That's more or less the answer I expected ;) But I have absolutely no clue on how to do that :) I'll check if I get an idea on how to do it and depending on that, we'll decide if I go for it or not. |
|
Hello I'll remove the WIP for the moment and let this PR be merged. I'll try to get the Laravel logik and do some experiments "off" but I need this PR into master so I can use it to create my users ;) Thanx |
PipoCanaja
changed the title
html/pages/edituser.inc.php
Outdated
| include 'includes/error-no-perm.inc.php'; | ||
| } else { | ||
| if ($vars['user_id'] && !$vars['edit']) { | ||
| $user_data = LegacyAuth::get()->getUser($vars['user_id']); | ||
| /** @var User $user */ | ||
| $user = User::all()->where('user_id', $vars['user_id'])->first(); |
There was a problem hiding this comment.
FYI, this is the long way of writing User::find($vars['user_id']); and actually loads all users from the db, then filters them in php.
html/pages/edituser.inc.php
Outdated
| @@ -432,7 +436,7 @@ | |||
| }//end if !empty($users_details) | |||
| }//end if | |||
| } else { | |||
| $user_list = LegacyAuth::get()->getUserlist(); | |||
| $userlist = User::all(); | |||
There was a problem hiding this comment.
You need to use User::thisAuth()->all(); to exclude users from inactive auths.
|
@PipoCanaja can you fix the queries I've pointed out and we'll merge this now and rewrite later :) |
html/pages/edituser.inc.php
Outdated
| @@ -264,7 +268,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| $users_details = LegacyAuth::get()->getUser($vars['user_id']); | |||
| $users_details = User::all()->where('user_id', $vars['user_id'])->first()->toArray(); | |||
There was a problem hiding this comment.
| $users_details = User::all()->where('user_id', $vars['user_id'])->first()->toArray(); | |
| $users_details = User::find($vars['user_id'])->toArray(); |
Hi team,
This PR was started because I lacked the "Edit Permission" capability for Active Directory users. I tried to find some kind of "minimal" changeset to achieve this.
And I like the little encouragement cause Edit Permissions works so far :) (tested it 5 minutes, time needed to create and edit permission on one new user)
I'll continue digging in this direction, but I would like to get your opinion and advice (and probably help as well) on this. I suppose you would prefer the complete refactor of the page (Auth object, Device object, getting rid of all select/update DB, etc etc), but I don't feel comfortable at all starting this, so I started "step by step" for the moment.
Let me know,
Thx,
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.