Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huawei iBMC absent state grey #9691

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Conversation

murrant
Copy link
Member

@murrant murrant commented Jan 17, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the Device 🖥️ New or added device support label Jan 17, 2019
@PipoCanaja
Copy link
Contributor

Hi,

That was a question to define if absent was normal or not, and I did not really found a proper answer so I stayed with green for absent.
Basically, a change of state from OK to absent is important. But a disk that was never installed should be green (absent is expected and normal in that case)

I am perfectly ok to change it, and i must say I did not try to find similar sensors to compare the values.

@murrant
Copy link
Member Author

murrant commented Jan 18, 2019

Up to you a lot of other MIBs call it 'notpresent'.

@PipoCanaja you choose to merge or close this. No worries.

@PipoCanaja
Copy link
Contributor

The majority of the /not( )?present/i states are already type "3" so I would say ibmc should be treated the same. Let's merge this.

Copy link
Contributor

@PipoCanaja PipoCanaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PipoCanaja PipoCanaja merged commit e2c4fa9 into librenms:master Jan 20, 2019
@murrant murrant deleted the ibmc-absent branch January 20, 2019 04:07
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants