Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always boot Laravel #9842

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Always boot Laravel #9842

merged 2 commits into from
Mar 14, 2019

Conversation

murrant
Copy link
Member

@murrant murrant commented Feb 18, 2019

That way we can depend on it being available.
Saves us crashes if some code accidentally uses something that isn't booted and a lot of silly if/elses.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

That way we can depend on it being available.
Saves us crashes if some code accidentally uses something that isn't booted and a lot of silly if/elses.
@murrant murrant merged commit c7c7b57 into librenms:master Mar 14, 2019
@murrant murrant deleted the laravel-always branch March 14, 2019 13:06
@vitalisator
Copy link
Contributor

have the same Problem here
https://community.librenms.org/t/weird-error/7698

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants