Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Cisco OTV (array)cast issue creating empty adj. #9968

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@PipoCanaja
Copy link
Contributor

commented Mar 15, 2019

Cisco OTV code is creating empty adjacencies on devices that do not run CiscoOTV at all. After digging, the culprit is a cast to array that does not check if there is data at all.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja added the Bug 🐞 label Mar 15, 2019

@PipoCanaja PipoCanaja changed the title Bug: Cisco OTV cast issue creating empty adj. Bug: Cisco OTV (array)cast issue creating empty adj. Mar 15, 2019

@PipoCanaja PipoCanaja self-assigned this Mar 15, 2019

@murrant murrant merged commit 5d512a8 into librenms:master Mar 15, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:cisco-otv branch Mar 15, 2019

@laf laf changed the title Bug: Cisco OTV (array)cast issue creating empty adj. Fixed Cisco OTV (array)cast issue creating empty adj. Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.