Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added location to alert hostname tooltip #9991

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

rmedlyn
Copy link
Contributor

@rmedlyn rmedlyn commented Mar 18, 2019

Show device location in alert hostname tooltip

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant
Copy link
Member

murrant commented Mar 18, 2019

Can you attach a screenshot?

@PipoCanaja
Copy link
Contributor

Tested and display is correct.

Copy link
Contributor

@PipoCanaja PipoCanaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PipoCanaja PipoCanaja merged commit b237e42 into librenms:master Mar 19, 2019
@rmedlyn rmedlyn deleted the AddLocToAlert branch March 20, 2019 16:42
@laf laf changed the title Add location to alert hostname tooltip Added location to alert hostname tooltip Mar 31, 2019
@laf laf added the WebUI label Mar 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants