Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write credentials to cache only if they are changed #1168

Closed
beaverking1212 opened this issue May 17, 2023 · 1 comment · Fixed by #1187
Closed

Write credentials to cache only if they are changed #1168

beaverking1212 opened this issue May 17, 2023 · 1 comment · Fixed by #1187

Comments

@beaverking1212
Copy link

Is your feature request related to a problem? Please describe.
A minor problem. When login with cached credentials and store_credentials is true in call to Session::connect() the file with cached credentials is written every time Session::connect() is called. The contents of the file usually do not change with these writes.

Describe the solution you'd like
The file with cached credentials should be written only if cached credentials have changed (have been updated by Spotify).

Describe alternatives you've considered
Set store_credentials to false and use code that writes credentials to cache if they are changed.
https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/blob/ea26d0d6d50bc0fd394c8934b14d18266671264b/audio/spotify/src/common.rs#L162

Additional context
Problem was noticed in: https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1195

@beaverking1212
Copy link
Author

@gdesmott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant