Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segv at chacha/chacha-merged.c:107 #7

Closed
znz opened this issue Aug 3, 2014 · 2 comments
Closed

Segv at chacha/chacha-merged.c:107 #7

znz opened this issue Aug 3, 2014 · 2 comments

Comments

@znz
Copy link

znz commented Aug 3, 2014

When EVP_CipherInit_ex call with key != NULL and iv == NULL, iv[n] are accessed without NULL check at https://github.com/libressl-portable/openbsd/blob/6e5b37ae2618b181b18de9cb33262259e681fb85/src/lib/libssl/src/crypto/chacha/chacha-merged.c#L108 .

Related backtraces are https://gist.github.com/znz/5cfd09976460a406bb6d#file-backtrace-txt-L69-L72
@ghost
Copy link

ghost commented Aug 5, 2014

Fixed in OpenBSD, will be merged soon. Thanks for the report!

@busterb
Copy link

busterb commented Aug 6, 2014

fixed in d8ea561

@busterb busterb closed this as completed Aug 6, 2014
busterb pushed a commit that referenced this issue Aug 20, 2019
Work towards supporting Cryptographic Message Syntax (CMS) in libcrypto.
b7b5eaa 
Cryptographic Message Syntax (CMS) is a standard for cryptographically
protecting messages, as defined in RFC 5652. It is derived from PKCS #7
version 1.5 and utilises various ASN.1 structures, making it complex and
fairly heavyweight. Various protocols - including RPKI (RFC 6480) - have
been built on top of it, which means it is necessary to support CMS, in
order to support RPKI.

This imports around 6,000 lines of code from OpenSSL 1.1.1, which is still
under the original OpenSSL license. Further work will occur in tree.

Requested by and discussed with many.

ok deraadt@ tb@
botovq pushed a commit that referenced this issue Jan 25, 2024
Fix various NULL dereferences in PKCS #12
0c15b62 
The PKCS #7 ContentInfo has a mandatory contentType, but the content itself
is OPTIONAL. Various unpacking API assumed presence of the content type is
enough to access members of the content, resulting in crashes.

Reported by Bahaa Naamneh on libressl-security, many thanks

ok jsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@znz @busterb