-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DH_set0_key wrongly checks for non-NULL arguments #92
Labels
Comments
Thanks for the report - this is a bug and will be addressed shortly. |
busterb
pushed a commit
that referenced
this issue
May 2, 2018
busterb
pushed a commit
that referenced
this issue
May 2, 2018
Reported by Ondřej Surý, LibreSSL-portable issue #92. ok inoguchi, jsing
Fixed in LibreSSL 2.7.3 that was released a few hours ago. Thanks again for the report. |
busterb
pushed a commit
that referenced
this issue
Feb 7, 2022
busterb
pushed a commit
that referenced
this issue
Feb 9, 2022
busterb
pushed a commit
that referenced
this issue
Feb 9, 2022
botovq
pushed a commit
that referenced
this issue
Sep 19, 2022
botovq
pushed a commit
that referenced
this issue
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The compatibility function
DH_set0_key
added in LibreSSL 2.7.0 has a different (possibly unwanted) behaviour from OpenSSL 1.1.0. In OpenSSL, it is perfectly OK to add just add pub_key to otherwise empty DH structure, e.g. this is OK:In LibreSSL, this would fail to set the internal structures because
dh->priv_key == NULL
.I don't think having quirks like this is desirable for users of both libraries.
The text was updated successfully, but these errors were encountered: