RSA key: ignore and warn about empty passphrase for NSS keys #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.nss used to recommend adding an empty passphrase for NSS keys in ipsec.secrets but commit 96d89e1 made any extra tokens errors which breaks old ipsec.secrets files when used with new libreswan versions. Ignore an empty passphrase token for now and log a warning about it saying it'll be an error in a future release. https://bugzilla.redhat.com/show_bug.cgi?id=1144941
|
I don't see the changes I made in libreswan github tree yet -- is the real development git tree hosted somewhere else? |
|
On Mon, 29 Sep 2014, Oskari Saarenmaa wrote:
The github tree is an "export only" tree. I just pushed it so you will |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.nss used to recommend adding an empty passphrase for NSS keys in
ipsec.secrets but commit 96d89e1 made any extra tokens errors which breaks
old ipsec.secrets files when used with new libreswan versions.
Ignore an empty passphrase token for now and log a warning about it saying
it'll be an error in a future release.
https://bugzilla.redhat.com/show_bug.cgi?id=1144941