Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli / env options to playout notify #1502

Closed
jooola opened this issue Jan 10, 2022 · 0 comments · Fixed by #1519
Closed

Add cli / env options to playout notify #1502

jooola opened this issue Jan 10, 2022 · 0 comments · Fixed by #1519
Assignees
@jooola
Labels
is: feature-request

Comments

@jooola
Copy link
Contributor

jooola commented Jan 10, 2022

See #1495 (comment)

playout-notify still has hardcoded values for the common options such as log filepath or log level.

We need to set this up with the new shared library. A small rework of the CLI is anyway really welcome for playout notify.
@jooola jooola self-assigned this Jan 12, 2022
@jooola jooola mentioned this issue Jan 17, 2022
Merged
jooola added a commit to jooola/libretime that referenced this issue Jan 17, 2022
@jooola
feat(playout): migrate notify cli to click
99c7f75 
Fixes libretime#1502

- replace notify option parser with click
- refactor call from liquidsoap to playout-notify

BREAKING CHANGE: the libretime-layout-notify log file in '/var/log/airtime/pypo-liquidsoap/notify.log' was removed and merged into the existing '/var/log/libretime/liquidsoap.log' log file.
paddatrapper pushed a commit that referenced this issue Jan 17, 2022
@jooola
feat(playout): migrate notify cli to click (#1519)
5364911 
Fixes #1502

- replace notify option parser with click
- refactor call from liquidsoap to playout-notify

BREAKING CHANGE: the libretime-layout-notify log file in '/var/log/airtime/pypo-liquidsoap/notify.log' was removed and merged into the existing '/var/log/libretime/liquidsoap.log' log file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jooola jooola

Labels
is: feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(playout): migrate notify cli to click jooola/libretime
1 participant
@jooola