-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: api, legacy wip: Move authentication to django api #2428
Conversation
ba547db
to
3d148ab
Compare
Codecov Report
@@ Coverage Diff @@
## main #2428 +/- ##
==========================================
+ Coverage 58.60% 61.91% +3.31%
==========================================
Files 146 145 -1
Lines 4343 4122 -221
==========================================
+ Hits 2545 2552 +7
+ Misses 1798 1570 -228
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
048871e
to
43f55e4
Compare
Django must send password-reset emails via smtp
43f55e4
to
662fbd1
Compare
Hey @togir2, Maybe @paddatrapper will be able to guide this week, I'll be afk. I didnt make a full review, but it seem you added some django views, which we don't want. The Api is meant to be headless. In the future we want to add a Vue based webapp that will talk to the api. We want to slowly transfom the frontend with parts of the new UI and not do a full rewrite. See the issue tracker, this has been discussed already. In addition I would like to weight the pros and cons about the sessions vs JWT, I would hate to break things because we didnt thought this trough. |
Sorry for the noise with the merge request.
Oh yes absolutely!
I though as I did the testing for me anyway I would share it with you all, maybe it would help finding a decision, or provide a concrete example to discuss. Sorry if that did sends the wrong signal... If will close this PR, as I'm sure this will not be the final solution and for discussion there is already the Issue #1788 |
It wasn't clear before your comment, but now that you cleared that up, feel free to keep the PR open for experimenting. And no worries, the noise does not bother. |
Description
I added a login and password reset pages to Django.
There are now the Following new Endpoints:
I also added an email section to the configuration file
Todo:
Links
#1788