Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: "RetroArch settings were potentially modified but not saved last time you opened it" #16097

Open
davidhedlund opened this issue Jan 9, 2024 · 3 comments

Comments

@davidhedlund
Copy link

davidhedlund commented Jan 9, 2024

Steps to reproduce the bug

  • Open RetroArch in Android.
  • Modify any setting.
  • Close Retroarch from Android. This will not save the setting.
  • Open Retroarch again. If: Settings -> Configuration -> Save Configuration on Quit: Enabled [default] it would be useful if RetroArch displayed a "RetroArch settings were modified but not saved last time you opened it, because it was not closed from "Main Menu -> Quit RetroArch"

Version/Commit

  • RetroArch: 1.16.0 (F-Droid)

Environment information

  • OS: Android
@odditude42
Copy link

if the settings aren't saved, how do you propose RetroArch knows that the settings aren't saved?

a method in which this data is recorded would also permit saving the settings, and moot the point of the request.

@davidhedlund davidhedlund changed the title Android: "RetroArch settings were modified but not saved last time you opened it" Android: "RetroArch settings were potentially modified but not saved last time you opened it" Jan 12, 2024
@davidhedlund
Copy link
Author

if the settings aren't saved, how do you propose RetroArch knows that the settings aren't saved?

a method in which this data is recorded would also permit saving the settings, and moot the point of the request.

This can be achieved by logging when:

  • Logging when RetroArch was opened.
  • Logging when RetroArch was closed from "Main Menu -> Quit RetroArch"
  • Compare the logs, if RetroArch was opened but not closed from "Main Menu -> Quit RetroArch", then it should send a notification like: "RetroArch settings were potentially modified but not saved last time you opened it, because it was not closed from "Main Menu -> Quit RetroArch"

@davidhedlund
Copy link
Author

davidhedlund commented Jan 14, 2024

Too much hazzle. I proposed this solution instead:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants