Replace "Quit RetroArch: Quit the program." with "Quit RetroArch. Save Configuration on Quit is [enabled]/[disabled]"

[davidhedlund]

Description

• In GNU/Linux the settings are closed when you close retorarch either from "Main Menu -> Quit RetroArch" or if you use the top right close window button
• In Android the settings in RA is not saved if you swipe-close the program. You have to quit retroarch from "Main Menu -> Quit RetroArch" to save the settings. But this is easy to forget.

Expected behavior

It would be useful if "Quit RetroArch: Quit the program." was replaced with "Quit RetroArch: Save the settings and quit the program."

Actual behavior

Steps to reproduce the bug

• Open RA
• In Home, scroll down to the "Quit RetroArch" entry

Bisect Results

[Try to bisect and tell us when this started happening]

Version/Commit

1.9.12

Environment information

• OS: Android 10

[sonninnos]

Except it does not save if you disable the option that saves on quit, so in that case it would need 2 sublabels..

Also that 1.9.12 version is very much obsolete, but sure this thing still applies.

[davidhedlund]

Except it does not save if you disable the option that saves on quit, so in that case it would need 2 sublabels.

Thank you. So to make it clear, the bold text below is desired under the specific circumstances:

If: Settings -> Configuration -> Save Configuration on Quit: Enabled [default]:

• Label: Quit. Sub label: "Quit RetroArch application and save settings."

If: Settings -> Configuration -> Save Configuration on Quit: Disabled:

• Label: "Quit. Sub label: Save Configuration on Quit is disabled."

Also that 1.9.12 version is very much obsolete, but sure this thing still applies.

Oh. Well, this is the current version on both Google Play, and F-Droid [incorrect].

[hizzlekizzle]

F-Droid should have an up-to-date version.

[davidhedlund]

F-Droid should have an up-to-date version.

You are right, the F-Droid release was 1.16.0. But the problem of this issue still applies.

[hizzlekizzle]

I think the main issue with this suggestion is that whether or not the settings are saved is contingent on the 'save settings on exit' setting, and I don't think we can make conditional menu text. That is, I believe it's hardcoded at compile time.

[davidhedlund]

I don't think we can make conditional menu text.

Can you please try to verify if it's possible or not?

That is, I believe it's hardcoded at compile time.

Sorry, I don't understand this, why not just modify the text before it's compiled?

[hizzlekizzle]

What I mean is: that statement wouldn't always be true, depending on whether or not 'save on exit' is enabled or not, and we have to set the menu text at compile time rather than being able to change it dynamically depending on what settings are enabled.

[davidhedlund]

What I mean is: that statement wouldn't always be true, depending on whether or not 'save on exit' is enabled or not,

Oh, I get your point: If there's nothing to save, then it's pointless with the extra added "Save the settings" text to the menu entry. I'll replace "Save the settings" with "Save modified settings" so it's always true, since that will indicate settings will not be saved if it's nothing is modified.

and we have to set the menu text at compile time rather than being able to change it dynamically depending on what settings are enabled.

Is it possible to change that?

[hizzlekizzle]

No, I mean this setting:

when it's OFF, "save the settings and quit the program" would not be true.

is it possible to change that?

Almost anything is possible, it's more a matter of: how much work it would be to do it, what benefit comes from doing it and who has the inclination to do it?

[davidhedlund]

No, I mean this setting: when it's OFF, "save the settings and quit the program" would not be true.

I discussed how to solve that with if statements here -- but yes that would require dynamic coding.

is it possible to change that?

Almost anything is possible, it's more a matter of: how much work it would be to do it, what benefit comes from doing it and who has the inclination to do it?

Thank you.

[davidhedlund]

• Quit RetroArch: Display "Saved new config to [config directory]/retroarch.cfg" before the program closes #16094
• Android: "RetroArch settings were potentially modified but not saved last time you opened it" #16097

[RobLoach]

I don't believe we have to be so verbose here. It does a few things when exiting, which is configurable, and I don't think we have to explain that. It's unnecessary bloat... If anything, I think we could remove the "RetroArch" from the menu label, as it's implied and explained in the sublabel.

[davidhedlund]

• Main Menu -> Restart/Quit RetroArch: Remove the "RetroArch" from the menu label #16119

[hizzlekizzle]

I think the verbosity is mostly to intended to disambiguate from the 'restart' and 'close content' entries in the quick menu. Nevertheless, I think there's a reasonable argument that it's unnecessarily verbose, though that has largely been our strategy for improving usability for n00bs: explain everything.

[davidhedlund]

If: Settings -> Configuration -> Save Configuration on Quit: Enabled [default]:

* Label: Quit. Sub label: "Quit RetroArch application and save settings."

If: Settings -> Configuration -> Save Configuration on Quit: Disabled:

* Label: "Quit. Sub label: Save Configuration on Quit is disabled."

@zoltanvb almost solved this, but the text: "Configuration save on exit is [enabled]/[disabled]." does not specify which configuration that is enabled or disabled. It should be updated to

• Save Configuration on Quit is [enabled]/[disabled].// distinguish from Save Remap Files on Quit (that I suggested here before) or
• Save Configuration on Quit is [enabled]/[disabled], Save Remap Files on Quit is [enabled]/[disabled].

[davidhedlund]

• retroarch.cfg comment for config_save_on_exit #16349