[CLI] --appendconfig is completely ignored when a core override exists

[LazyBumHorse]

Description

If a core has a core override (even an empty one), then any setting from --appendconfig is being ignored when a game is directly loaded from CLI á la
retroarch --appendconfig <config>.cfg -L <core> <game>

Expected behavior

I expect the core overrides to work on a per-setting basis in the fashion of
core override > appendconfig > config (> default)
So a setting in appendconfig should be used when it's not set in the core override.

Steps to reproduce the bug

1. Have a core override like config/Snes9x/Snes9x.cfg
2. Start retroarch.exe --appendconfig <config>.cfg -L core/snes9x_libretro.dll <game>
3. See none of the settings have been applied*

* currently, --appendconfig settings are written to the current config file (see #1718), which you can also observe not happening.

Version

• RetroArch: master 1e863b0
• OS: Windows 7

[hizzlekizzle]

I believe that's a result of overrides basically being an automated application of --appendconfig

[LazyBumHorse]

That would explain it, although I wonder why --appendconfig leaks into the current config, while overrides do not.
Makes me want to refactor all this too...

[andres-asm]

I wrote overrides.
The way overrides work is:

• Load the regular config
• Apply overrides

And when you're done with the content

• Load the regular config again

I use the append code underneath, appending is the wrong term since what it actually does is put the partial config on top, the way the config_file_loader works look for the first instance of any key.

The manual append action doesn't have the "restore" mechanism.

[konsumschaf]

Just wanted to open a bug on this and found this one - is there any chance for a fix?