Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config appendconfig + saving + logging #14505

Merged
merged 2 commits into from Oct 12, 2022

Conversation

sonninnos
Copy link
Collaborator

Description

This tackles a few config related issues:

  • Allows use of --appendconfig with override cfgs instead of getting ignored
  • No more console startup logging if logging to file
  • Saves config on exit only once instead of 3 times by
    • Making sure retroarch_main_quit() isn't called many times at once where possible, and also by doing saving depending on shutdown flag to prevent it from firing more than once
    • Removing saving from main_exit()

Also some indentation corrections and nits.

Related Issues

Closes #9007
Closes #5457

@LibretroAdmin LibretroAdmin merged commit 50ace05 into libretro:master Oct 12, 2022
@sonninnos sonninnos deleted the config-appendconfig branch October 12, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI] --appendconfig is completely ignored when a core override exists appendconfig does not work
2 participants