revert glslang changes from 58b22b0 which broke some shaders #10843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this commit should fix it instead - let me know if this works. The shader preset works again on my end at least with this change. I'd rather us go with this commit since that way I don't have to revert all the beneficial changes I made here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears that 58b22b0 caused some problems with slang shaders. Specifically, it broke the presets/scalefx+rAA+aa.slangp shader, which reports this error:
Related Issues
This has been reported on the forums but nowhere else AFAIK.
Related Pull Requests
No related PRs.
Reviewers
@twinaphex