(cheevos) add option to play custom sound on achievement unlock #11010
Conversation
| @@ -1141,7 +1141,7 @@ static const camera_driver_t *camera_drivers[] = { | |||
|
|
|||
| #define AUDIO_BUFFER_FREE_SAMPLES_COUNT (8 * 1024) | |||
|
|
|||
| #define MENU_SOUND_FORMATS "ogg|mod|xm|s3m|mp3|flac" | |||
| #define MENU_SOUND_FORMATS "ogg|mod|xm|s3m|mp3|flac|wav" | |||
There was a problem hiding this comment.
Is there a specific reason wav was not included in this list? I did notice that the rwav library didn't like any of my .wav files that contained metadata.
There was a problem hiding this comment.
I can confirm the wav file won't play if any metadata is present. I wouldn't be surprised if that's why it was excluded. Easy to miss that being the cause in testing.
There was a problem hiding this comment.
Tested and confirmed working with wav (tagless), ogg, and flac. As noted, any metadata in the wav file will prevent playback.
Unlock sound file should be added to https://github.com/libretro/retroarch-assets/tree/master/sounds
|
Built and tested here, and hey! That's really cool! 😄 |
|
I think people will be very excited for this. |
Description
Adds the ability to play a sound file (
assets/sounds/unlock.*) when an achievement unlocks.Builds on #8106, but doesn't require Menu Sounds to be enabled.
General question: How do we provide a default sound file so users won't complain about it not working when they enable it?
Related Issues
#10503
Related Pull Requests
n/a
Reviewers
@twinaphex @meleu @Sanaki