Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux] Add missing include in nbio_linux.c. #11170

Merged
merged 1 commit into from Aug 10, 2020
Merged

[linux] Add missing include in nbio_linux.c. #11170

merged 1 commit into from Aug 10, 2020

Conversation

ericonr
Copy link
Contributor

@ericonr ericonr commented Aug 10, 2020

Description

On musl-libc, the compiler would print a warning for nbio_linux.c:
"warning: 'struct timespec' declared inside parameter list will not be
visible outside of this definition or declaration", indicating a missing
header defining this structure.

Reviewer

@twinaphex

@inactive123
Copy link
Contributor

inactive123 commented Aug 10, 2020

hi, this looks like a good enough fix

However, the PR as it currently stands introduces some Travis build failures for the other platforms (I assume the glibc-based Linux compiles).

Can you attempt to fix these while also ensuring musl compatibility at the same time?

https://travis-ci.org/github/libretro/RetroArch/builds/716424461

@ericonr
Copy link
Contributor Author

ericonr commented Aug 10, 2020

Yeah, I saw :/

I'm currently trying to investigate a more correct way of solving this.

On musl-libc, the compiler would print a warning for nbio_linux.c:
"warning: 'struct timespec' declared inside parameter list will not be
visible outside of this definition or declaration", indicating a missing
header defining this structure.

On glibc, this definition is provided through the stdlib header.
@ericonr
Copy link
Contributor Author

ericonr commented Aug 10, 2020

This is probably the more correct header. Is its position in the includes fine?

@ericonr
Copy link
Contributor Author

ericonr commented Aug 10, 2020

For travis, the only issue seems to have been in xcode11 ?

0.03s$ security import dev.p12 -k build.keychain -P $OSX_CERT_PASS -T /usr/bin/codesign
security: SecKeychainItemImport: One or more parameters passed to a function were not valid.
The command "security import dev.p12 -k build.keychain -P $OSX_CERT_PASS -T /usr/bin/codesign" exited with 1.

@inactive123
Copy link
Contributor

The Xcode 11 build failing is just Apple notarization shenanigans, sometimes it works and sometimes it doesn't based on Apples' automated response times. So yeah that is a red herring. Guess we'll merge this and hope for the best with this PR. If it results on build failures on other platforms, I'll get back to you.

@inactive123 inactive123 merged commit 508ba27 into libretro:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants