Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable menu navigation also with right analog stick #14579

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

sonninnos
Copy link
Collaborator

Description

As per request allow using both analog sticks in menu.

Threshold had to be included in order to keep input being overwritten when the other stick is read.

@LibretroAdmin LibretroAdmin merged commit 1aa258f into libretro:master Nov 2, 2022
@sonninnos sonninnos deleted the menu-analog-sticks branch November 2, 2022 15:19
@zzedmore
Copy link

zzedmore commented Nov 3, 2022

Now only my right analogue works in the menu. How do I enable the left analogue again ? D-pad works.

I'm on Android if that makes any difference.

@sonninnos
Copy link
Collaborator Author

sonninnos commented Nov 3, 2022

Uhh both work fine here.. that was the whole point.

So I guess this should be reverted then until I can somehow reproduce that issue..? Or maybe for some reason that situation hits those general_binds which didn't happen here, since I assumed those were for keyboard binds, and thus not needed. In that case it is just a simple copypaste operation.

Even running with fallback, as in autoconf profile deleted it still works here.

@sonninnos
Copy link
Collaborator Author

Ok, if that does not help, then let's say goodbye to the idea.

@zzedmore
Copy link

zzedmore commented Nov 3, 2022

Maybe it's just an Android thing ? It would be good if someone else could confirm this. All I did was update Retroarch with the Nightly build (Android) and the Left Analogue no longer worked in the menu but the Right one did. I'll have to wait until tomorrow for the buildbot to try your addition (assuming they push it in time).

@sonninnos
Copy link
Collaborator Author

Not acceptable in any case no matter the platform. Thanks for testing regardless, and please do confirm as soon as that is merged and pushed out.

@zzedmore
Copy link

zzedmore commented Nov 4, 2022

Good news, both analogue sticks work in the menu now !

@sonninnos
Copy link
Collaborator Author

Whew, awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants