Remove language specific msg_hash_xx.c files #15218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After PR libretro#14821 , the contents of msg_hash_xx.c files are present in the normal translation workflow. Since that time, almost all languages have either caught up on Crowdin, or are still on such low level of translation completeness, that removing these entries does not harm usability. Only Chinese Simplified and Portuguese Brazilian languages remain in separate files, as they may still be considered an improvement over Crowdin status. See also commit 568ffac.
AnthonySibl
added a commit
to AnthonySibl/RetroArch
that referenced
this pull request
Apr 27, 2023
This reverts commit 80296a6.
zoltanvb
added a commit
to zoltanvb/libretro-docs
that referenced
this pull request
May 21, 2023
After libretro/RetroArch#15218, separate msg_hash_xx.c files are no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After PR #14821 , the contents of msg_hash_xx.c files are present in the normal translation workflow. Since that time, almost all languages have either caught up on Crowdin, or are still on such low level of translation completeness, that removing these entries does not harm usability.
Only Chinese Simplified and Portuguese Brazilian languages remain in separate files, as they may still be considered an improvement over Crowdin status.
See also commit 568ffac.