(video_driver) fix windowed viewport with libretro rotation #15247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbudreadmon
changed the title
|
Don't merge yet, it doesn't seem correct with a 304x224 game |
|
Tested on rotated games with resolutions that aren't a multiple of their ratio (304x224 and 256x224), it seems correct now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the viewport seems wrong when running rotated games in windowed mode: a rotated 320x240 game with a 3x scaling will output
[INFO] [Video]: Set video size to: 540x720.instead of[INFO] [Video]: Set video size to: 720x960., the original resolution will even be downsized if you run it at 1x scaling.This PR should fix this, i don't think it affects anything besides rotated games running in windowed mode, however i'm not familiar with that code so correct me if i'm wrong.