Xunkar's AI service rework updated #15640
Conversation
Made sure to unload the overlay on release and when the server returns empty values in automatic modes.
Moved image display to the main thread for now
|
Well you've been busy while I was sleeping, good work :D |
|
Thank you! I'm glad I could help. :) Definitely take a look at it. I wasn't sure how to test it out |
|
@LibretroAdmin Dunno if you want to try and sneak this in before the next stable or push the stable out first so this can be tested in nightlies. |
|
Couple of things:
|
|
Ok it should be good now @LibretroAdmin. Lmk if there's anything wrong or else that needs to be fixed |
cpod12
force-pushed
the
ai_service_rework
branch
from
9a08914
to
d26e88e
Compare
|
OK, so now we're in the final stretch of this PR being approved, I've asked @BarryJRowe to review this as well since he created the AI code. |
|
As a test, I tried this with FF1 on a nestopia core with the ztranslate.net service, and it only reported no text found with just the word error reported in the log. Master branch works fine, so it's not a configuration issue. Last time there was an issue with supporting the GL driver, so I tried changing the driver to vulkan, or glcore, but it just gave the same error. Requests going to the service look to be properly formatted, and the service returns valid results, but they are not being parsed. |
|
Considering it used to work, I think it's related to the recent changes made by @cpod12 specifically in |
|
Any luck @cpod12 ? The main thing I'm concerned about is compatibility with the existing services. |
|
Sorry @BarryJRowe. I was out of town for the last week. I'll look into all that soon. Do you have advice for running cores with builds? I don't know how to do that. |
|
Nvm don't answer that. It shows it in the build guide lol. |
|
So I'm having trouble getting content to run. After I load a core and get to content that I try to run it says no core found even with the core selected. Does anyone know what could be causing this? |
|
Nvm again lol. I figured it out. It should be working ok now @BarryJRowe. Lmk if there's anything wrong or if you're having any issues |
|
I'll try to check it out either over the current weekend, or early next week. |
|
I've done some testing and after updating the ztranslate service it looks good to me. The only suggestion I have would be to merge the latest of master into the branch and test before merging. On a side note however, there should be some documentation available on what's expected for the subs output from the remote api server, as well as any additional information about the automatic functionality with an example implementation. |
|
Ok, that should be fine. @xunkar would you be able to add that documentation? I'm not familiar with it enough to write that. Especially the second part about the automatic functionality. |
|
accessibility.h has all the documentation necessary, has it not? |
Authors who want to develop their own API should not have to dig through the C code as a first step (to get specifics that's understandable, but not just to start out with trying to understand a basic request). I would recommend making changes to this page: https://docs.libretro.com/guides/ai-service/ Github link for what file to change to do so: https://github.com/libretro/docs/blob/master/docs/guides/ai-service.md As an example, the ztranslate service api documentation was given here when it was first released: https://ztranslate.net/docs/service though it has added some more features over time. Enough information should be provided to get something working, such as the input format for the body, and the other valid input queries. Things that you did not change (like the key pressing stuff) don't have to be added, but things like the new subs type should be explained. Specifics of the implementation can be point the reader to the retroarch code. |
|
OK, I did my best. But I'm not a native english speaker, so it may not be a bad idea to proof-read my work. Also, I have no idea how to merge the change (it's over at https://github.com/xunkar/docs) with this particular PR. |
|
You can just do a PR from your docs fork to the docs repo and then link that PR here as a "merge this one too". |
|
Oh ok thanks. However, I have no idea why, but somehow the commit is nowhere to be found now? I edited the file and all… and I don't know it reverted back, and I have no local copy. This… might take a while. |
|
is it here? https://github.com/xunkar/docs/tree/patch-1 |
|
You're a life saver, thanks :D |
|
I'm going to assume @BarryJRowe tested this. |
* AI service rework * File missing * Fixed C89 build * Fixed usage of inline for C89 build * Fixed an overlay unloading bug Made sure to unload the overlay on release and when the server returns empty values in automatic modes. * Fixed forward decl (c89) * Fixed OpenGL texture loading Moved image display to the main thread for now * Changed some formatting slightly * Fixed struct variable order and put brackets on newlines * Moved pointer, fixed retroarch.cfg, and replaced strlcat with strlcpy * Fixed catenation issue * Fixed a few other catenation issues * Fixed one more concatenation issue * Fixed concatenation issue * Fixed a few other concatenation issues * Fixed one more concatenation issue * potential fix for parsing issue --------- Co-authored-by: Xunkar <329857+xunkar@users.noreply.github.com>
Original PR by Xunkar here #15175.
This one should be up to date and able to automatically merge.