Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set save redirect paths before set_environment #15820

Merged
merged 1 commit into from Oct 24, 2023

Conversation

sonninnos
Copy link
Collaborator

@sonninnos sonninnos commented Oct 20, 2023

Description

  • Fix setting savefile_directory in override file by moving redirect set before environment set
  • Add final path to RETRO_ENVIRONMENT_GET_SAVE_DIRECTORY logging, and renamed to SAVE_DIRECTORY like SYSTEM_DIRECTORY
  • Comment cleanups

Without this change the path changing does work with --appendconfig, but not with overrides, even though overrides are parsed right after appends in the same manner.

So is there a better way, or can this cause other problems? Sure feels like the current order is clearly wrong in any case, and this seems fine as far as I can tell. What harm could there be for the core to get the final paths as early as possible..?

libretro.h does not explicitly say one way or the other, but makes sense to me that those paths are ready to be fetched already in retro_set_environment() and not later in retro_load_game(), since the paths are environment vars after all.

@LibretroAdmin LibretroAdmin merged commit 06d5cd3 into libretro:master Oct 24, 2023
22 checks passed
@sonninnos sonninnos deleted the override-save-path branch October 24, 2023 14:37
JoeOsborn pushed a commit to JoeOsborn/RetroArch that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants