-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package *.lck core lock file-extension. #16556
Package *.lck core lock file-extension. #16556
Conversation
Includes *.lck alongside the rest of the cores/$platform/cores so that bundled cores can be locked at time of publish.
Hmm, Android failure appears unrelated. |
Why are you doing this though for this core? I don't understand why we need to prevent it from getting updated, this seems undesirable. |
the PR just allows lock files to be included, right? not specifying scummvm, specifically? But yeah, I agree with LibretroAdmin that ScummVM core should be update-able, right? Some, like mupen-via-ANGLE, need to be locked, though. |
Correct, Android and any other build is un-related, this PR only effects the UWP version. |
Yeah, seems fine to me. |
@LibretroAdmin So what is the verdict on this? |
The adjustments make it possible to lock cores using pre-generated *.lck files, simplifying the process for new forks and custom builds. This is particularly beneficial for developers who need to maintain locked cores. It may be a specific issue to UWP that requires this but it is still an important addition. |
Description
Re-introduce .lck file-type extension into .vcxproj & vcxproj.filters for RetroArch-msvcUWP.
Example: For demonstrative purpose.
The LCK file will be packed with the .appx package when published, which is a use case for locking cores included with specialised builds by default.
Thoughts
I am not entirely sure what reason there was to not have the lock file included with UWP configuration as this is particularly useful with Xbox specific builds and required to protect custom cores included in special builds in order for those cores to be skipped by Online Updater. You can still unlock the core manually from the Cores Settings page.
Related Issues
No Issue
Related Pull Requests
None