Fix build with ffmpeg snapshots. #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to wonder why they keep doing this nonsense - coming up with new defines that are just renamed defines anyway. They are just needlessly breaking code and backwards compatibility constantly. |
|
Yea, its a bit silly... |
|
Btw, thanks for fixing the compat with older ffmpeg versions. That was easier than I thought it would be... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5717
I tested this with all of the supported ffmpeg releases.
Which all continued to work.
I also tested two unsupported releases.
Unfortunately this commit will break the ancient
2.6.3, but I am not sure anyone is or should be using that anymore and this might be unavoidable?