[WiiU] Toolchain: Actually fix C++ constructors/destructors (oops!) #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like I temporarily forgot how external symbols work. Fixes https://gbatemp.net/posts/7720955; hopefully we finally have C++ under control.
|
Thanks for your contributions @QuarkTheAwesome. It's much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't quite get this right the first time. I've thoroughly tested these new patches against a core that actually needs constructors to function (ControllerPatcher didn't, apparently) so I know it works. Fixes this problem.
Also; I've noticed that calling
__finifrom the RPX build causes elf2rpl to error out. It doesn't do this if I change__finito not use__DTOR_END__; so that's almost certainly the cause. Since it links just fine; I'll submit a bug report to the creators in the hope we can get destructors working on RPX. (EDIT: issue is devkitPro/wut#60)Thanks again,
Ash