Update file_stream.c (It causes slow "Scan directory" option on Linux) #6250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It causes slow "Scan directory" option on Linux.
lodgerz
changed the title
|
@bparker06 I wonder what could be the actual underlying cause for this? Maybe the HAVE_MMAP codepath is just very slow and maybe we should get rid of it? |
|
I can confirm that just removing HAVE_MMAP greatly speeds up the scanning. |
|
Let me know if this gives you the same speedup as this PR here. It did for @bparker06 at least. |
|
@twinaphex yes, with last commit scan directory is fast. Good Job! |
|
OK, I will close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It causes slow "Scan directory" option on Linux. The problem starts from this commit:
72fdfb1