travis: Attempt to fix xcode9.3 travis build.

[orbea]

Description

This attempts to fix the travis build with xcode9.3, its failing to build because moc is not in the path. I guess homebrew is not installing it and how hard can it be to fix that?

I am not sure this is right, do not merge unless travis passes first.

Related Issues

xcode9.3 travis build failure

   /bin/sh -c /Users/travis/libretro-super/retroarch/pkg/apple/build/RetroArch_Metal.build/Release/RetroArchQt.build/Script-053FC2782143764B00D98D46.sh
/usr/local/opt/qt/bin/moc -o ui/drivers/moc_ui_qt.cpp ui/drivers/ui_qt.h
make: /usr/local/opt/qt/bin/moc: No such file or directory
/usr/local/opt/qt/bin/moc -o ui/drivers/qt/moc_ui_qt_load_core_window.cpp ui/drivers/qt/ui_qt_load_core_window.h
make: /usr/local/opt/qt/bin/moc: No such file or directory
make: *** [ui/drivers/moc_ui_qt.cpp] Error 1
make: *** Waiting for unfinished jobs....
make: *** [ui/drivers/qt/moc_ui_qt_load_core_window.cpp] Error 1

** BUILD FAILED **

Reviewers

Do not merge unless travis passes!

[orbea]

See comment Homebrew/brew#5513 (comment).

[orbea]

@twinaphex I guess this is good for now given this is a workaround for an upstream bug...

[orbea]

Actually its still failing even if the travis build passes...

** BUILD FAILED **
The following build commands failed:
	CompileC build/RetroArch_Metal.build/Release/RetroArchQt.build/Objects-normal/x86_64/griffin_objc.o /Users/travis/libretro-super/retroarch/griffin/griffin_objc.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
buildbot job: retroarch: [status: done] [recipes/apple/retroarch-osx-x64]
buildbot message: retroarch: [status: done] [recipes/apple/retroarch-osx-x64]
Packaging
The command "./build-retroarch-metal.sh" exited with 0.

Regardless this has to do with metal is out of scope for this PR.

[inactive123]

So you still want me to merge this or not?

[orbea]

@twinaphex Its part of the fix for the xcode9.3 travis builds, another part is here libretro/libretro-super#932 and the last part should be done in a new PR probably by someone that actually can use metal.

[orbea]

@twinaphex To rephrase, there are three points of failure, this PR fixes the first one.

[orbea]

@twinaphex This is good and is blocking other fixes, do you have any issues?

[RobLoach]

Brewed.

[RobLoach]

Merging, updating the dependencies in xcode 9.3 allows Travis to build properly, fixing our automated tests. Thanks Orbea 👍

[orbea]

@RobLoach Its still not fully fixed, travis is getting the wrong error code and succeeding erroneously while there is still a metal build issue.

This also needs to be merged to fix the error code which will expose the final issue. libretro/libretro-super#932

As for the final issue where metal is not actually building, I think it might be missing dependencies, but I can't find any documentation or info about installing metal on osx or travis.

[RobLoach]

Hmm, I'll check through some of the Travis logs. Thanks for the update. Would be great to be able to leverage the automated testing more.

[orbea]

Also in the future it may be good to revert this change when the upstream homebrew issue is resolved and the CI provider updates their homebrew appropriately. It likely makes the build a little longer with brew update.

Edit: I guess its fixed, just the CI provider hasn't updated and who knows when that will happen...

Homebrew/brew#5517

[RobLoach]

Let's keep watch, when Travis updates, then we won't have to worry about that update call ourselves. In the mean time, is there some caching we could add to help speed up the process?

[orbea]

For reference here is the current status the of xcode9.3 build without the libretro-super fix.

In file included from /Users/travis/libretro-super/retroarch/griffin/griffin_objc.m:72:
In file included from /Users/travis/libretro-super/retroarch/griffin/../gfx/common/metal/Context.m:9:
/Users/travis/libretro-super/retroarch/griffin/../gfx/common/metal/Context.h:47:36: error: no type or protocol named 'CAMetalDrawable'
@property (nonatomic, readonly) id<CAMetalDrawable> nextDrawable;
                                   ^
/Users/travis/libretro-super/retroarch/griffin/../gfx/common/metal/Context.h:53:33: error: expected a type
                         layer:(CAMetalLayer *)layer
                                ^
In file included from /Users/travis/libretro-super/retroarch/griffin/griffin_objc.m:72:
/Users/travis/libretro-super/retroarch/griffin/../gfx/common/metal/Context.m:577:59: error: property 'texture' not found on object of type 'id'
      rpd.colorAttachments[0].texture = self.nextDrawable.texture;
                                                          ^
/Users/travis/libretro-super/retroarch/griffin/../gfx/common/metal/Context.m:580:42: error: property 'texture' not found on object of type 'id'
         _backBuffer = self.nextDrawable.texture;
                                         ^
4 errors generated.

** BUILD FAILED **
The following build commands failed:
	CompileC build/RetroArch_Metal.build/Release/RetroArchQt.build/Objects-normal/x86_64/griffin_objc.o /Users/travis/libretro-super/retroarch/griffin/griffin_objc.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
buildbot job: retroarch: [status: done] [recipes/apple/retroarch-osx-x64]
buildbot message: retroarch: [status: done] [recipes/apple/retroarch-osx-x64]
Packaging
The command "./build-retroarch-metal.sh" exited with 0.

Note.

** BUILD FAILED **

And (Return code of 0 means no error.)

The command "./build-retroarch-metal.sh" exited with 0.

I'm not very well informed about travis so I am not sure about caching here, but this PR could compensate and make it faster. libretro/libretro-super#931