Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable RXML and purge libxml #8486

Merged
merged 1 commit into from Mar 23, 2019
Merged

Re-enable RXML and purge libxml #8486

merged 1 commit into from Mar 23, 2019

Conversation

huwpascoe
Copy link
Contributor

Fixed rxml to work with griffin.c

Related Issues

#7419

Fixed rxml to work with griffin.c
@orbea
Copy link
Contributor

orbea commented Mar 17, 2019

Would you mind elaborating more on the point of this PR? What is libxml2 even used for in RetroArch?

@huwpascoe
Copy link
Contributor Author

huwpascoe commented Mar 17, 2019

libxml2 isn't used for anything, it's been commented out with #ifdef 0 for a while it seems.
rxml is needed for the linked issue.

@orbea
Copy link
Contributor

orbea commented Mar 17, 2019

Rather, why was libxml added in the first place?

@huwpascoe
Copy link
Contributor Author

I think maybe it was for opengl xml shaders or something like that?

@orbea
Copy link
Contributor

orbea commented Mar 17, 2019

Sounds plausible, thanks for satisfying my curiosity.

@markwkidd
Copy link
Contributor

GLSL XML shaders I guess? https://docs.libretro.com/development/shader/xml-shaders/

@orbea
Copy link
Contributor

orbea commented Mar 18, 2019

Just for reference that page says.

XML shaders as a whole are deprecated in RetroArch, and will not be selectable in RGUI. You can still use them via video_shader config option. To use GLSL in RetroArch, the new GLSL shaders format is used, which mirrors the Cg shaders implementation quite well. The new GLSL shaders only support modern style, no fixed function. To convert XML shaders into straight GLSL, see GLSL shaders.

@hizzlekizzle Is it worth supporting XML shaders anymore? I imagine most shaders have been converted for glsl and slang by now?

@hizzlekizzle
Copy link
Contributor

@orbea No, zero point AFAIK. I'm not sure if the "game-aware" shader functionality was ever added to the modern shader backends, but they were only ever proofs of concept anyway.

@ghost

This comment was marked as spam.

@huwpascoe
Copy link
Contributor Author

I'm not going to be dealing with expat, sorry. This is just for #7419 if someone else wants to improve xml support later they can.

@hizzlekizzle hizzlekizzle requested review from inactive123 and a user March 23, 2019 00:27
@inactive123 inactive123 merged commit 123cd67 into libretro:master Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants