Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto crop for PAL games. #719

Closed
backgamon opened this issue Sep 13, 2020 · 3 comments
Closed

Auto crop for PAL games. #719

backgamon opened this issue Sep 13, 2020 · 3 comments

Comments

@backgamon
Copy link

backgamon commented Sep 13, 2020

Since 706a4e6 black bars show on many PAL games.
A option are added for cropping, but many need a differents values for each.
It almost never be perfect...

Expected behavior

No black bars same as 7993527.

Steps to reproduce the bug

Just launch any PAL games on latest build.

Bisect results

I compiled a old version with some of the new change (XBR and textures correcting), but i'm unable to add all changes like Lightrec and RSX...
There are any chances to add a option/switch to disable (or enable) a system like the older?
Same as Duckstation:
crop

Environment information

Retroarch 1.9.0
Windows 10 Pro x64 [19041.508]
Gigabyte 2070 RTX 8G OC [452.06]

@IngwiePhoenix
Copy link

IngwiePhoenix commented Sep 18, 2020

Definitively having the same issue. I switched from DuckStation to this core - because it actually supports SBI files. DuckStation does not. Many of my PAL rips actually need that (Crash Bash being one of these).

I enabled the frame display. It fits pretty snug into that border, ironically.
image

An option to get rid of those would be nice. That with 16:9 and upscaled internal renderer is pretty amazing.

But those bars...kinda annoy me. My TV is an old 55" from 2011 and already has thick bezels - I don't need any more than I already have. :)

EDIT: I manually adjusted the scanline offsets:
image
This needs to be a feature. Oof... ^^;

@backgamon
Copy link
Author

backgamon commented Sep 18, 2020

[EDIT]For who want a old version[18 october2019] with all correction about XBR and Corrupted texture+ i successfully added the last PGXP 2d correction.

https://mega.nz/file/cmZUnSRT#hfAVTpBar38mP81j0P8h6wVUS0vMyYVwYSJEiwFClLw

Lightrec and all new change (except correction and PGXP 2D) are unavailable...i can't add...

@ds22x
Copy link
Contributor

ds22x commented Sep 30, 2021

I believe this has been solved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants