Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a core option and bump version number #64

Merged
merged 5 commits into from
Jul 8, 2021
Merged

Fix a core option and bump version number #64

merged 5 commits into from
Jul 8, 2021

Conversation

RokkumanX
Copy link
Contributor

Upon further inspection, the CPU core option in beetle-vb-libretro was set to disabled and as far as I can see there is only fast and accurate to choose from to begin with.

I took the liberty and changed it from disabled to accurate as default, end users can always change it later on.

Also, the beetle-vb-libretro core must be somewhat up to date so I also took the liberty and bumped the version number to match the recent Mednafen 1.27.1 release.

This is just a proposal PR, feel free to change or close it if you want.

@negativeExponent
Copy link
Contributor

by default, if CPU Emulation mode is not set to "accurate", then it will use "fast".

https://github.com/libretro/beetle-vb-libretro/blob/master/libretro.cpp#L2435-L2437

better set this to "fast" in core option label, instead of "accurate" as the default, unless accurate does not cause issues, like performance loss for low-powered devices/consoles/platforms, etc.

@RokkumanX
Copy link
Contributor Author

RokkumanX commented Jun 23, 2021

I didn't know that, however the core options isn't documented with comments so when I saw the CPU option set to disabled when there is only fast and accurate to choose from my natural reaction were that something was faulty configured.

Anyway, here's what I know about the CPU Emulation option from the current available documentation found on the Mednafen Virtual Boy page.

Fast Mode
Fast mode trades timing accuracy, cache emulation, and executing from hardware registers and RAM not intended for code use for performance.

Accurate Mode
Increased timing accuracy, though not perfect, along with cache emulation, at the cost of decreased performance. Additionally, even the pipeline isn't correctly and fully emulated in this mode.

I don't know what people have setup wise when they emulate stuff but if you are on a fairly modern system, Accurate Mode shouldn't cause any performance problems at all.

I honestly can't believe that the Virtual Boy, of all consoles could be that of a demanding system to emulate but I could very much be wrong.

However I'm thinking PC as usual and I know there are more low-powered devices/consoles/platforms that maybe could be affected.

In the end it's only a setting, and low-powered devices always have the option to choose either.
I know, I know the same can be said in reverse that high-performance setups could change from fast to accurate.

I'm a guy that always prefers accuracy settings opposed to settings that reduces accuracy, yes it's my opinion and people don't have listen to it and I know that too.

@inactive123
Copy link
Contributor

Can you set this to 'fast' by default? I'd be willing to merge it after that.

@RokkumanX
Copy link
Contributor Author

OK, I think it should be good now.

@inactive123
Copy link
Contributor

@negativeExponent You OK with merging this in its current state? If yes, I will do so.

@negativeExponent
Copy link
Contributor

@negativeExponent You OK with merging this in its current state? If yes, I will do so.

looks fine as is. other than hw_cpu/v810, the main core should be almost in sync so the version number bump is fine as well.

@inactive123 inactive123 merged commit d515923 into libretro:master Jul 8, 2021
@ruijtunes ruijtunes mentioned this pull request Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants