Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make disks swappable for multidisk games #30

Open
meepingsnesroms opened this issue Jan 13, 2017 · 4 comments
Open

Make disks swappable for multidisk games #30

meepingsnesroms opened this issue Jan 13, 2017 · 4 comments

Comments

@meepingsnesroms
Copy link
Contributor

No description provided.

@xmassound
Copy link

Please make this happen!!!

@meepingsnesroms
Copy link
Contributor Author

I just fixed the disk swapping code, I dont know of any games that show the disk swap screen within 5 minutes so I cant test it, but it may be fully working now and if anyone has a multi disk game they want to play, please post the test results.

@msheehan79
Copy link
Contributor

msheehan79 commented Nov 2, 2017

I just tried a couple multi-disk games and every time you load a new disk it reboots the emulator, so a lot of games that require starting with Disk A then swapping disks won't work. Confirmed I am on the latest build as of today (41f7f15) so I'm guessing the fix applied to prevent autorestart on disk change wasn't effective.

I am using an RPI3 in case that turns out to be helpful.

A good game to test this is Gandhara, it is a 2 disk game where disk 1 is the intro and disk 2 is the game itself so you can load disk 1 and pretty much immediately get to the prompt for disk 2 to verify the results.

For what it is worth, I had used Gandhara to test and was able to successfully swap disks on that game before these recent commits.

EDIT - I just tried RetroArch with the latest core build on Windows 10 and everything works fine there.
On the RPI3 I rolled back the core build back as far as c32e06c and also RetroArch back to v1.6.7 release and I still see the issue on the Pi3. I know I had tested this on the Pi a few weeks ago and it worked, so there is still an issue, but it's looking more like something going on with my setup as opposed to a core issue since it does work fine elsewhere.

@msheehan79
Copy link
Contributor

After some further testing and comparison of my RetroArch config files, I have found that if the option "rgui_browser_directory" is set in the config file, it causes RA to restart whenever a disk image is appended.

This happens with other multi disk cores too like PCSX-rearmed so it's a RetroArch rather than a core issue. Going to log an issue there as next step but just an FYI should anyone else run into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants