Make disks swappable for multidisk games

[meepingsnesroms]

No description provided.

[xmassound]

Please make this happen!!!

[meepingsnesroms]

I just fixed the disk swapping code, I dont know of any games that show the disk swap screen within 5 minutes so I cant test it, but it may be fully working now and if anyone has a multi disk game they want to play, please post the test results.

[msheehan79]

I just tried a couple multi-disk games and every time you load a new disk it reboots the emulator, so a lot of games that require starting with Disk A then swapping disks won't work. Confirmed I am on the latest build as of today (41f7f15) so I'm guessing the fix applied to prevent autorestart on disk change wasn't effective.

I am using an RPI3 in case that turns out to be helpful.

A good game to test this is Gandhara, it is a 2 disk game where disk 1 is the intro and disk 2 is the game itself so you can load disk 1 and pretty much immediately get to the prompt for disk 2 to verify the results.

For what it is worth, I had used Gandhara to test and was able to successfully swap disks on that game before these recent commits.

EDIT - I just tried RetroArch with the latest core build on Windows 10 and everything works fine there.
On the RPI3 I rolled back the core build back as far as c32e06c and also RetroArch back to v1.6.7 release and I still see the issue on the Pi3. I know I had tested this on the Pi a few weeks ago and it worked, so there is still an issue, but it's looking more like something going on with my setup as opposed to a core issue since it does work fine elsewhere.

[msheehan79]

After some further testing and comparison of my RetroArch config files, I have found that if the option "rgui_browser_directory" is set in the config file, it causes RA to restart whenever a disk image is appended.

This happens with other multi disk cores too like PCSX-rearmed so it's a RetroArch rather than a core issue. Going to log an issue there as next step but just an FYI should anyone else run into this.