Mention explicitly that some GBA cores do not support "SaveRAM Autosave Interval" setting #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With data from the discussion on this issue: libretro/RetroArch#16323
explaining a bit better why that might lead to loss of data.
|
Since the SRAM autosave feature is a RetroArch feature, I would normally suggest that it's not really appropriate for the libretro docs pages beyond the checkmark (or lack thereof) in the libretro features section. That is, it doesn't apply to any other libretro frontends, which might handle saving in a different way without using the libretro save interface. However, I do know this is a significant problem for people, so I'm not against having some sort of additional notice. I would prefer if it appeared down with the libretro features, though, rather than up at the main explanation of the core. |
|
No problem, I can move the content down. |
Move SRAM Autosave Interval information to the table below
Move SaveRAM Autosave Interval down
explain that it only affects if used from within RetroArch
adds explicit mention to SaveRAM Autosave Interval support
adds SaveRAM Autosave Interval
Adds SaveRAM Autosave Interval
|
Done; also added the line to the cores that do support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent loss of data when using internal saving and exiting RetroArch in a non-graceful way, as addressed on libretro/RetroArch#16323 and many other times.