Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: creating empty disk images through libretro interface #91

Closed
ofry opened this issue Dec 10, 2021 · 8 comments · Fixed by #110
Closed

Feature request: creating empty disk images through libretro interface #91

ofry opened this issue Dec 10, 2021 · 8 comments · Fixed by #110

Comments

@ofry
Copy link

ofry commented Dec 10, 2021

Related to #43 (comment)

It can "work" in PC. But if I launch core from some hacked game console with CFW? Or I have Lakka without direct access to shell etc.?

etc. etc.

Related to #90. If we have libretro SRAM interface, so all "new-created empty disks with some content placed by core" we can store via libretro SRAM interface.

@cayce-msx
Copy link
Contributor

Sure, I can build this. But just out of curiosity: what would you use this functionality for on a game console (without physical keyboard)?

Note that a virtual keyboard is not there (see #22 - would require a modification to RetroArch itself) so there would be no way to enter a BASIC program - which is the only thing you can do with an empty disk; an empty disk makes an MSX boot into the MSX-BASIC prompt (REPL, to use a more modern term ;).

@gingerbeardman
Copy link
Contributor

Some games require an empty user disk for saves.

eg. The Golf (1989, Pack-In-Video)

https://www.generation-msx.nl/software/pack-in-video/the-golf/1121/

https://gamefaqs.gamespot.com/msx/953282-the-golf/faqs/77373/loading

@cayce-msx
Copy link
Contributor

Ah. That would only be useful for multidisk games. I just implemented that using m3u files. Adding an empty disk to that set beforehand would seem more intuitive to me. But, if you guys really think you can benefit from it I'll whip up some code. There's an RGUI menu option to append a fresh image to the set. Note that I have no way of saving that, since there is no file name given. That'll have to wait until #90.

cayce-msx added a commit to cayce-msx/fmsx-libretro that referenced this issue Dec 27, 2021
…ation when DISK.ROM is required but not loaded
@cayce-msx
Copy link
Contributor

cayce-msx commented Dec 27, 2021

Hey @ofry @gingerbeardman I just pushed an implementation for this at https://github.com/cayce-msx/fmsx-libretro/tree/create-empty-disk-images. Could you compile & test that, to see if this is what you are looking for? If you're not able to build yourself, I could also directly send a PR to autechre, but preferably I'd first have your feedback before doing that. Otherwise just scroll through the code (I'm hoping you both can read C?). Be sure to also verify the new section 'Creating empty disk images' in the readme against your expectations.

Note: I'll look at #90 separately.

@gingerbeardman
Copy link
Contributor

I'm away for holiday break right now so can't build for a week. FWIW

@ofry
Copy link
Author

ofry commented Dec 27, 2021

@cayce-msx could you do this for cassette tape too?

@cayce-msx
Copy link
Contributor

I'll repeat what I just stated in #40: "As for tape, I'll leave that for someone else to build." This issue is about creating disk images, and I'm happy keeping that scope.

You have a way of keeping a person busy ;)

@ofry
Copy link
Author

ofry commented Dec 27, 2021

OK. Then you can make the PR from https://github.com/cayce-msx/fmsx-libretro/tree/create-empty-disk-images and close this issue.

inactive123 pushed a commit that referenced this issue Jan 12, 2022
* #91: Optionally create empty disk images. Also show a notification when DISK.ROM is required but not loaded

* quick disk swap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants