Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, with the yabasanshiro libretro core, i can't use glsm on android without adding some definition to glsm.
The first idea was to apply this patch : https://pastebin.com/raw/gGuYwbnz , however it would end up disappearing if someone decided to regenerate those files
The second idea was to generate
glsym_es31.h
andglsym_es31.c
by running glgen.py onGLES3/gl31.h
, but the generated files didn't end up well (i had to tinker with them to build the core, and when it finally built, it crashed)That's why i came up with this third solution : it allows the developper to add his own gl symbol by simply defining
HAVE_GLSYM_PRIVATE
and having a file namedglsym_private.h
in the include dirs, it works well, is flexible, and is less intrusive than the other solutions.As a proof of concept i managed to deal with all my issues by creating the following files :