Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GBA cheat codes cleanup! #1157

Merged
merged 1 commit into from May 4, 2021
Merged

GBA cheat codes cleanup! #1157

merged 1 commit into from May 4, 2021

Conversation

davidgfnet
Copy link
Contributor

This commit decrypts most of the encrypted CodeBreaker cheat codes into
their plain format. I manually fixed some games that had both plain and
encrypted codes, causing some of them not to work.

The advantage of having all codes in plain format is that it allows for
users to add their codes (appending the file). Encryption prevents this
since the cheat decoder tries to decrypt unconditionally.

Added a tiny python script that assists in decoding these cheatcodes. It
is not very smart so it might decrypt stuff that's already decrypted
depending on the order of the cheats in the file.

I manually eveyballed all the codes and ran some sanity checks on them
to the point I trust most of the changes here. Some codes were already
broken so I hopefully mend more things that I'm breaking with this
change.

Sorry for the whitespace cleanup! That's the script rewriting the files
cleanly

Copy link
Member

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looking great 👍 ... While I am not versed on the core internals for cheats here, they seem like some good clean up. Thanks a lot.

This commit decrypts most of the encrypted CodeBreaker cheat codes into
their plain format. I manually fixed some games that had both plain and
encrypted codes, causing some of them not to work.

The advantage of having all codes in plain format is that it allows for
users to add their codes (appending the file). Encryption prevents this
since the cheat decoder tries to decrypt unconditionally.

Added a tiny python script that assists in decoding these cheatcodes. It
is not very smart so it might decrypt stuff that's already decrypted
depending on the order of the cheats in the file.

I manually eveyballed all the codes and ran some sanity checks on them
to the point I trust most of the changes here. Some codes were already
broken so I hopefully mend more things that I'm breaking with this
change.

Sorry for the whitespace cleanup! That's the script rewriting the files
cleanly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants