Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mame 0.78 database for MAME 2003 - FB Alpha updated to v0.2.97.38 - New Game and Watch database #139

Merged
merged 12 commits into from Jun 11, 2016

Conversation

lollo78
Copy link
Contributor

@lollo78 lollo78 commented Jun 8, 2016

No description provided.

…ersion (without BIOS and issue with charset)
…ersion (without BIOS and issue with charset)
Considering that https://github.com/libretro/libretro-fba support v0.2.97.38, I decided to update the previous Kivutar FBA dat (v0.2.97.36).
The only romset v0.2.97.38 available on the Web is created from the same guy who released also the v0.2.97.36. But now, he use a different approach: now he merge the clones into the parents roms to save disk space.
Considering that most people who download this romset will not split the clones from the respective parents, I propose to update our dat/rdb on the new (merged) romset. 
For now, my dat calculate the CRC of the zip file (not the zip content). This because libretro-fba can't manage merged roms.
One day (adding merged roms support into the core), maybe, calculating the CRC of the content could be a best solution. Of course, in this case I'll update again the file.
Considering that https://github.com/libretro/libretro-fba support v0.2.97.38, I decided to update the previous Kivutar FBA dat (v0.2.97.36).
The only romset v0.2.97.38 available on the Web is created from the same guy who released also the v0.2.97.36. But now, he use a different approach: now he merge the clones into the parents roms to save disk space.
Considering that most people who download this romset will not split the clones from the respective parents, I propose to update our dat/rdb on the new (merged) romset. 
For now, my dat calculate the CRC of the zip file (not the zip content). This because libretro-fba can't manage merged roms.
One day (adding merged roms support into the core), maybe, calculating the CRC of the content could be a best solution. Of course, in this case I'll update again the file.
@lollo78 lollo78 changed the title Mame 0.78 database for MAME 2003 Mame 0.78 database for MAME 2003 - FB Alpha updated to v0.2.97.38 Jun 8, 2016
…ersion (without BIOS and issue with charset)

Sorry there was still a BIOS in the database.
…ersion (without BIOS and issue with charset)

Sorry there was still one BIOS in the database
@RobLoach
Copy link
Member

RobLoach commented Jun 8, 2016

Looks like a lot of removals:

+24,504 −208,398

You sure this is right?

@lollo78
Copy link
Contributor Author

lollo78 commented Jun 9, 2016

Yes! If you want done also your check/test.

For FBA the reason is described also in PR comment. From now, the only FBA Complete Collection v0.2.97.38 available on the Web merge clones into parents. So, instead of a splitted romset of 4771 roms, we have only 1454 roms.

For MAME, the only 0.78 full romset available is on TPB and it includes 4718 .zip file (about 15 BIOS file). But of course it contains also not working, majhong and other crap. I included all the file inside the database (like for FBA) - but not the BIOS - to respect the full romset (but, for personal use, I cleaned my romset at 1990 file :D).
I decided for mame2003 (mame 0.78) because is the only mame core that works on all the platform (also on Rpi). If it's not an issue for you, please add it to the origin master. The actual MAME.dat (without CRC) doesn't work (always empty playlist). So, why don't overwrite it?

In Retroarch I scanned both romset and I created the two playlists without issues (there are all the games inside and there aren't conflict from MAME and FBA .lpl).

@inactive123
Copy link
Contributor

Don't overwrite the main MAME database like this. Instead, make a separate database DAT file and rdb for MAME 2003.

@lollo78
Copy link
Contributor Author

lollo78 commented Jun 9, 2016

ok, I'll push it as soon as possible

lollo78 added a commit to lollo78/libretro-super that referenced this pull request Jun 9, 2016
@lollo78
Copy link
Contributor Author

lollo78 commented Jun 9, 2016

@twinaphex
Done!
I also made a PR for the info file
libretro/libretro-super#289

@inactive123 inactive123 merged commit 60e3458 into libretro:master Jun 11, 2016
@lollo78 lollo78 changed the title Mame 0.78 database for MAME 2003 - FB Alpha updated to v0.2.97.38 Mame 0.78 database for MAME 2003 - FB Alpha updated to v0.2.97.38 - New Game and Watch database Jun 12, 2016
@markwkidd
Copy link
Contributor

markwkidd commented Aug 22, 2016

Hi @lollo78 sorry I lost track of this thread and only just now found it. The new database does not work with a Non-Merged set (several reports about this in the forum as well.)

I opened an issue about Non-Merged sets in response: #248

@barbudreadmon
Copy link

What are the advantages of non-merged sets ? I mean, except being a lot more lazy (finding parent of your clone sure is a lot of work...). On the other side split sets help to save disk space, which is a good thing overall, and is needed on embedded if you want a full set.

@markwkidd
Copy link
Contributor

markwkidd commented Aug 23, 2016

From my perspective I would say it this way: all of the console systems
supported by the RetroArch database are Non-Merged. Learning what the
different kinds of Arcade sets even mean has been full of confusion for the
libretro development team (I could create a list of issues, pull requests,
and forum threads where this mild confusion is on display)

Even with better docs, split sets are unintuitive. Plus, the size
difference between a complete (including CHDs) Non-Merged MAME 0.139 set
and a complete split set is only ~25%. I would bet its similar for the
other MAME cores in libretro.

The questions: What kind of technical proficiency is RetroArch shooting for
in terms of its users? Once you know that:is the 25% space savings enough
of a tradeoff for making this much more complicated to the end user.

Another way to ask this is, would RetroArch want to start using Merged sets
for its console systems? That is technically possible, and I would go so
far as to say it wouldn't be hard to switch to that with the tools already
in place. In a world where non-merged sets are available.

@barbudreadmon
Copy link

Console systems are non-merged sets because, unlike arcade systems, there is no purpose in having split sets for 99% of them.

25% space saving is a lot on sd card / ssd.

I know a few end users and none of them ever had an issue with current split sets (and i'm talking about people not especially accustomed to computers).

I can't share your perspective.

@markwkidd
Copy link
Contributor

I was saying that we could theoretically save a lot of space by moving to Merged sets for consoles. (Split doesn't really make sense, I agree).

Overall though it does seem like we must agree to disagree about arcade sets. :) I enjoy the conversation though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants