2003-plus shares sample folder with 2003

[mediamoshpit]

Currently, the 2003-plus core shares a sample folder with the 2003 core. Seeing as how they make use of several different samples, the two can't really coexist without issues.

[mediamoshpit]

Ah, ok. I didn't know they were there was a different naming scheme. So, I take it that all the unique samples to this core have a different name? Is there a list as to what those names are. I looked through the commit comments and didn't see a reference, but I might have missed it. Regarding the ROM, I believe my issue was with an incomplete transfer. After I sent the same file again, the game launched fine.

[dankcushions]

you might get away with dkong samples being in a merged file (although that adds a step to the user to manually merge them), but sharing this file will cause more problems. eg: hiscore.dat is kept in the same system_dir, but if roms appear differently in memory between these updated roms, that will cause issues for plus when using the shared hiscore.dat. it'll start reading and writing to the wrong memory ranges.

also, the hardcoded emu name will cause issues with all the savefile generated stuff:
/libretro savefile dir/mame2003/diff/
/libretro savefile dir/mame2003/nvram/
/libretro savefile dir/mame2003/hi/
/libretro savefile dir/mame2003/cfg/
/libretro savefile dir/mame2003/inp/
/libretro savefile dir/mame2003/memcard/
/libretro savefile dir/mame2003/snap/

eg, are the internal memory savefiles (.nv/nvram) compatible across both versions?

also, i think the all the core options should be renamed to mame2003-plus. eg: https://github.com/libretro/mame2003-libretro/blob/604844b2a0cd76890289049f3a823ae76172816c/src/libretro/libretro.c#L43

• probably want to have unique entries for this core to allow them to be configured separately.

[mediamoshpit]

I merged the samples and even found an existing sample with the files merged and neither produced sound in dkongx with mame2003-plus. All are named correctly according to your previous post, but I still may be missing something. I realize github isn't really the place for support issues, but I thought I'd at least document my personal experience here. To that end, I'll also note that I was able to get dkongx to run in lr-fbalpha and get full audio with the merged samples.