Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make save selection text prettier. Fix walking through tight spots. #90

Merged
merged 2 commits into from Nov 16, 2021
Merged

Conversation

crocket
Copy link
Contributor

@crocket crocket commented Nov 15, 2021

After merging this pull request, I think nxengine-libretro shouldn't have obvious gameplay issues. Now, the game is an immersive experience rather than a rude wake-up call for open source contribution. I can now experience nxengine-libretro as a game, not as an open source project with strange quirks to be fixed.

By using variable width text in save selection, text looks pretty. There is no overflow because the longest text for save selection is "Egg Observation Room?".

Before

Doukutsu-211116-083745

After

Doukutsu-211116-083844

The last change to sprites_sif.h broke walking through tight spots. Without walking through the tight spots, I couldn't beat the game. It was a serious issue. By reducing the width of Block D(feet), the player character can walk through tight spots in plantation jail and sand zone.

Block U (width of head) should be wide enough to make horizontal jump through one block gap easy. If it is too wide, the player character can't jump vertically through one block gap.

2021-11-16 08:05:06
If Block U is not wide enough, it becomes difficult to jump through this gap which is one block tall because Block U is used to detect collision with the top of this gap.
mpv-shot0003

Block D (width of feet) should be narrow enough to squeeze through tight spots in sand zone and plantation. If it is too narrow, the player's feet could probably submerge into the ground often. If Block D is too wide, the player character can accidentally squeeze horizontally through one glock gap while falling down because Block D is used to detect collision with block gaps while falling down. Block D of the player character in nxengine-evo is so wide that it is so easy to horizontally slip through block gaps while falling down. In cave story engine 2 which is the original freeware codebase, it is not possible to accidentally slip through block gaps while falling down.

2021-11-16 08:05:17
Sand Zone
mpv-shot0004
Plantation jail
mpv-shot0005

By using variable width text, text looks pretty.
There is no overflow because the longest text for save selection is
"Egg Observation Room?".
By reducing the width of Block D(feet), the player character can
walk through tight spots in plantation jail and sand zone.
@inactive123
Copy link
Contributor

Awesome work!

@inactive123 inactive123 merged commit 4e2ea9f into libretro:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants