Use dynamic base address for 3ds #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I found the commit that made this change f72db18. Seems the dynamic base is actually desired, but the author misunderstood what "DRC_CACHE_BASE" means.... |
|
OK - I do agree that maybe it might be safest to put those variables back on heap instead of stack in RetroArch - since consoles typically have very small stack size, so stack size should definitely not be abused. So, I think the best approach is that we merge this PR in addition to me doing something about the stack size increases in RA. |
|
1.6.7 still crashing for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest, I have no idea of what I'm doing here.
This is a fix for #125. The increasing size of global variables in RetroArch codebase causes the BASE_ADDR to overlap with some of the variables, resulting in a crash.
I don't know if there's a reason why dynamic base is not used for 3ds. According to my tests everything seem to be working fine.