Add Trooper 2 #838
Merged
Add Trooper 2 #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #828
RobLoach
commented
May 13, 2022
| input_r_x_plus_btn = "1" | ||
| input_r_x_minus_btn = "1" | ||
| input_r_y_plus_btn = "1" | ||
| input_r_y_minus_btn = "1" |
There was a problem hiding this comment.
Going to merge for now, we could fix later on.
There was a problem hiding this comment.
This file looks wrong for several reasons:
- why so many inputs (16 total) mapped to "1"?
- the physical joystick has NO analog inputs.
- device name is padded with spaces and ill-formed.
- duplicate vendor and product id (VID & PID) with "Hyperkin_Trooper_V2.cfg"
- no labels
Conclusion: this file should be deleted.
|
The file added in this commit looks corrupt. There are 16 in total digital and analog inputs all assigned to "1". The VID and PID are identical to a similarly named file "Hyperkin Trooper V2". This was discussed here https://github.com/libretro/retroarch-joypad-autoconfig/issues/828 but for some reason was missed in the merge. |
|
Good catch, @dcaputi1. Let's revert this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #828