RPI: crash during startup

[gizmo98]

RetroArch reports an 2410 segfault:
RetroArch: rarch_log_libretro: libretro INFO :: Got size: 320x320
RetroArch: rarch_log_libretro: libretro INFO :: Quake Libretro -- TyrQuake Version 0.62
RetroArch WARN :: gl_glsl_init :: GL : Stock GLSL shaders will be used.
2410 Segfault

I compiled tyrquake with retropie https://github.com/petrockblog/RetroPie-Setup/blob/master/scriptmodules/libretrocores/tyrquake.sh. Was anything important changed this month? The script worked Nov. 16.

[inactive123]

Do a git bisect and report back.

[joolswills]

I bisected it to this commit - 4a14dd2

[inactive123]

I guess they're on an old version of RetroArch that did not yet have this environ callback.

[joolswills]

this is with retroarch v1.0.0.3 - ce57697 so not old

[inactive123]

Try if this fixes anything -

c2ee3b5

[joolswills]

funnily enough I just did that - well

diff --git a/common/sys_libretro.c b/common/sys_libretro.c
index d86ba85..cfd2884 100644
--- a/common/sys_libretro.c
+++ b/common/sys_libretro.c
@@ -618,7 +618,7 @@ static void update_env_variables(void)

    if (environ_cb(RETRO_ENVIRONMENT_GET_USERNAME, &default_username))
    {
-      if (default_username[0] != '\0')
+      if (default_username != NULL && default_username[0] != '\0')
       {
          char setplayer[256];
          sprintf(setplayer, "name %s", default_username);

works with above code

[joolswills]

I see the fix is in. Cheers :)