(libretro.c) Clean up file path handling + fix segfault when loading content from 'non-standard' directories #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the core will segfault on certain platforms when loading PAK files from non-standard directories (anything other than
id1
,quoth
,hipnotic
,rogue
) due to illegal usage ofstrncpy()
. This can be observed most easily by attempting to run the shareware version of Quake from RetroArch's online content downloader.This PR fixes the issue, and also cleans up all file path handling in
libretro.c
(usinglibretro-common
routines). A number oflibretro-common
files have also been updated to the latest version.