Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors #121

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
5f05ce9
(snd_dma.c) Remove unnecessary console commands
LibretroAdmin Jun 7, 2022
8685a8d
* Get rid of various console commands that will never be used for the…
LibretroAdmin Jun 7, 2022
c1fbd4c
r_pixbytes is always going to be 1 for the libretro core, get rid
LibretroAdmin Jun 7, 2022
e0cc02b
Get rid of unused msg_suppress_
LibretroAdmin Jun 7, 2022
fe821a7
Get rid of some unused variables as a result of earlier code refactors
LibretroAdmin Jun 7, 2022
4f468cc
Get rid of unused frontend VID_ functions in libretro.c
LibretroAdmin Jun 7, 2022
94bf7b8
(Sound) Optimize around 16bit stereo sound, libretro port will
LibretroAdmin Jun 7, 2022
c1636b1
* Remove unused IN_Commands
LibretroAdmin Jun 8, 2022
7b8ec43
* Remove unneeded debug code (including member variable height of sur…
LibretroAdmin Jun 8, 2022
431694a
Remove if 0 codeblocks
LibretroAdmin Jun 8, 2022
d4f4167
No need for if 1 statements
LibretroAdmin Jun 8, 2022
e6023ef
Remove demo recording
LibretroAdmin Jun 8, 2022
6e408de
Remove unused variables that got incremented every frame
LibretroAdmin Jun 8, 2022
f62cf64
Remove scr_ram/scr_net and DrawNet
LibretroAdmin Jun 8, 2022
bbc5d8e
r_recursiveaffinetriangles is always enabled
LibretroAdmin Jun 8, 2022
3fc527c
Get rid of r_drawentities - remove more unused functions
LibretroAdmin Jun 8, 2022
2d3450a
Don't write keybinds to config.cfg
LibretroAdmin Jun 9, 2022
67bb497
Remove unused function call declarations for rfprintf
LibretroAdmin Jun 9, 2022
7fb147f
Cleanups
LibretroAdmin Jun 9, 2022
edc4517
Miscellanous cleanups - turn functions static if we can
LibretroAdmin Jun 9, 2022
63d299a
Get rid of unnecessary console commands viewframe, viewmodel, viewmod…
LibretroAdmin Jun 9, 2022
a30501b
* COM_LoadPakFile - CRC checking on PAK file is unnecessary
LibretroAdmin Jun 9, 2022
85b6e57
Get rid of unused variables r_fullbright, r_ambient, r_pointfile
LibretroAdmin Jun 9, 2022
4914587
Get rid of unused snd_noextraupdate
LibretroAdmin Jun 9, 2022
6ed9256
Remove unused cl_warncmd
LibretroAdmin Jun 9, 2022
7750e1c
Remove unused extern
LibretroAdmin Jun 9, 2022
ededcc5
Cleanups
LibretroAdmin Jun 9, 2022
3ce2b42
Cleanups in pr_exec.c
LibretroAdmin Jun 9, 2022
e98949c
Simplify code - get rid of unused net_win files
LibretroAdmin Jun 9, 2022
fb10716
Doesn't read or write to config.cfg anymore - options will be added
LibretroAdmin Jun 9, 2022
1f1c389
Cleanups
LibretroAdmin Jun 9, 2022
170a75e
Remove unused R_LeadingEdgeBackwards
LibretroAdmin Jun 9, 2022
36c4b0d
* r_edge - don't go through function pointer
LibretroAdmin Jun 9, 2022
c439cc6
Remove D_CheckCacheGuard debug function
LibretroAdmin Jun 9, 2022
67bd259
remove unused R_LineGraph
LibretroAdmin Jun 9, 2022
c7d6d6d
Remove unused code - DebugLog
LibretroAdmin Jun 11, 2022
e168696
Remove unused variables
LibretroAdmin Jun 11, 2022
8a3b554
Remove pcx_t
LibretroAdmin Jun 11, 2022
8d94cd3
Remove unused FPS_20 code and other miscellaneous unused things˜
LibretroAdmin Jun 11, 2022
cfe5014
Cleanups for pr_edict.c/cl_input.c
LibretroAdmin Jun 11, 2022
a8ea1e1
Remove unused Sys_Printf
LibretroAdmin Jun 11, 2022
a273599
Get rid of unused BOPS_Error
LibretroAdmin Jun 11, 2022
e04da40
* Use fill_pathname_join where possible instead of snprintf
LibretroAdmin Jun 12, 2022
10a70d6
No return value for Sys_Error
LibretroAdmin Jun 12, 2022
9911d91
Cleanups
LibretroAdmin Jun 12, 2022
2169d02
S_StopAllSounds - argument is always true
LibretroAdmin Jun 13, 2022
1947981
General cleanups
LibretroAdmin Jun 13, 2022
1e2464b
Cut down on some strlens
LibretroAdmin Jul 22, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion Makefile.common
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ SOURCES_C := \
$(CORE_DIR)/common/r_part.c \
$(CORE_DIR)/common/r_sky.c \
$(CORE_DIR)/common/r_sprite.c \
$(CORE_DIR)/common/r_vars.c \
$(CORE_DIR)/common/r_surf.c \
$(CORE_DIR)/common/rb_tree.c \
$(CORE_DIR)/common/sbar.c \
Expand Down
103 changes: 0 additions & 103 deletions QW/client/cl_cam.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,6 @@ Cam_Lock(int playernum)
static pmtrace_t
Cam_DoTrace(vec3_t vec1, vec3_t vec2)
{
#if 0
memset(&pmove, 0, sizeof(pmove));

pmove.numphysent = 1;
VectorCopy(vec3_origin, pmove.physents[0].origin);
pmove.physents[0].model = cl.worldmodel;
#endif

VectorCopy(vec1, pmove.origin);
return PM_PlayerMove(pmove.origin, vec2);
}
Expand Down Expand Up @@ -408,75 +400,6 @@ Cam_Track(usercmd_t *cmd)
}
}

#if 0
static float
adjustang(float current, float ideal, float speed)
{
float move;

current = anglemod(current);
ideal = anglemod(ideal);

if (current == ideal)
return current;

move = ideal - current;
if (ideal > current) {
if (move >= 180)
move = move - 360;
} else {
if (move <= -180)
move = move + 360;
}
if (move > 0) {
if (move > speed)
move = speed;
} else {
if (move < -speed)
move = -speed;
}

//Con_Printf("c/i: %4.2f/%4.2f move: %4.2f\n", current, ideal, move);
return anglemod(current + move);
}
#endif

#if 0
static void
Cam_SetView(void)
{
return;
player_state_t *player, *self;
frame_t *frame;
vec3_t vec, vec2;

if (cls.state != ca_active || !cl.spectator || !autocam || !locked)
return;

frame = &cl.frames[cls.netchan.incoming_sequence & UPDATE_MASK];
player = frame->playerstate + spec_track;
self = frame->playerstate + cl.playernum;

VectorSubtract(player->origin, cl.simorg, vec);
if (cam_forceview) {
cam_forceview = false;
vectoangles(vec, cam_viewangles);
cam_viewangles[0] = -cam_viewangles[0];
} else {
vectoangles(vec, vec2);
vec2[PITCH] = -vec2[PITCH];

cam_viewangles[PITCH] =
adjustang(cam_viewangles[PITCH], vec2[PITCH],
cl_camera_maxpitch.value);
cam_viewangles[YAW] =
adjustang(cam_viewangles[YAW], vec2[YAW], cl_camera_maxyaw.value);
}
VectorCopy(cam_viewangles, cl.viewangles);
VectorCopy(cl.viewangles, cl.simangles);
}
#endif

void
Cam_FinishMove(usercmd_t *cmd)
{
Expand All @@ -490,32 +413,6 @@ Cam_FinishMove(usercmd_t *cmd)
if (!cl.spectator) // only in spectator mode
return;

#if 0
if (autocam && locked) {
frame = &cl.frames[cls.netchan.incoming_sequence & UPDATE_MASK];
player = frame->playerstate + spec_track;
self = frame->playerstate + cl.playernum;

VectorSubtract(player->origin, self->origin, vec);
if (cam_forceview) {
cam_forceview = false;
vectoangles(vec, cam_viewangles);
cam_viewangles[0] = -cam_viewangles[0];
} else {
vectoangles(vec, vec2);
vec2[PITCH] = -vec2[PITCH];

cam_viewangles[PITCH] =
adjustang(cam_viewangles[PITCH], vec2[PITCH],
cl_camera_maxpitch.value);
cam_viewangles[YAW] =
adjustang(cam_viewangles[YAW], vec2[YAW],
cl_camera_maxyaw.value);
}
VectorCopy(cam_viewangles, cl.viewangles);
}
#endif

if (cmd->buttons & BUTTON_ATTACK) {
if (!(oldbuttons & BUTTON_ATTACK)) {

Expand Down
14 changes: 0 additions & 14 deletions QW/client/cl_demo.c
Original file line number Diff line number Diff line change
Expand Up @@ -636,20 +636,6 @@ CL_Record_f(void)
}
}

#if 0
MSG_WriteByte(&buf, svc_updatestatlong);
MSG_WriteByte(&buf, STAT_TOTALMONSTERS);
MSG_WriteLong(&buf, cl.stats[STAT_TOTALMONSTERS]);

MSG_WriteByte(&buf, svc_updatestatlong);
MSG_WriteByte(&buf, STAT_SECRETS);
MSG_WriteLong(&buf, cl.stats[STAT_SECRETS]);

MSG_WriteByte(&buf, svc_updatestatlong);
MSG_WriteByte(&buf, STAT_MONSTERS);
MSG_WriteLong(&buf, cl.stats[STAT_MONSTERS]);
#endif

// get the client to check and download skins
// when that is completed, a begin command will be issued
MSG_WriteByte(&buf, svc_stufftext);
Expand Down
11 changes: 1 addition & 10 deletions QW/client/cl_ents.c
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,6 @@ FlushEntityPacket(void)
int word;
entity_state_t olde, newe;

Con_DPrintf("FlushEntityPacket\n");

memset(&olde, 0, sizeof(olde));

cl.validsequence = 0; // can't render a frame
Expand Down Expand Up @@ -274,12 +272,9 @@ CL_ParsePacketEntities(qboolean delta)
cl.frames[newpacket].invalid = false;

if (delta) {
from = MSG_ReadByte();
from = MSG_ReadByte();

oldpacket = cl.frames[newpacket].delta_sequence;

if ((from & UPDATE_MASK) != (oldpacket & UPDATE_MASK))
Con_DPrintf("WARNING: from mismatch\n");
} else
oldpacket = -1;

Expand Down Expand Up @@ -851,13 +846,11 @@ CL_LinkPlayers(void)
if (msec <= 0
|| (!cl_predict_players.value && !cl_predict_players2.value)) {
VectorCopy(state->origin, ent->origin);
//Con_DPrintf ("nopredict\n");
} else {
// predict players movement
if (msec > 255)
msec = 255;
state->command.msec = msec;
//Con_DPrintf ("predict: %i\n", msec);

oldphysent = pmove.numphysent;
CL_SetSolidPlayers(j);
Expand Down Expand Up @@ -971,13 +964,11 @@ CL_SetUpPlayerPrediction(qboolean dopred)
(!cl_predict_players.value && !cl_predict_players2.value) ||
!dopred) {
VectorCopy(state->origin, pplayer->origin);
//Con_DPrintf ("nopredict\n");
} else {
// predict players movement
if (msec > 255)
msec = 255;
state->command.msec = msec;
//Con_DPrintf ("predict: %i\n", msec);

CL_PredictUsercmd(state, &exact, &state->command, false);
VectorCopy(exact.origin, pplayer->origin);
Expand Down
13 changes: 0 additions & 13 deletions QW/client/cl_input.c
Original file line number Diff line number Diff line change
Expand Up @@ -706,16 +706,3 @@ CL_InitInput(void)

Cvar_RegisterVariable(&cl_nodelta);
}

// FIXME - unused function?
#if 0
/*
============
CL_ClearStates
============
*/
static void
CL_ClearStates(void)
{
}
#endif