Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding X and Y Buttons as extra keys for L and R #40

Merged
merged 1 commit into from Apr 19, 2016
Merged

Adding X and Y Buttons as extra keys for L and R #40

merged 1 commit into from Apr 19, 2016

Conversation

LodanZark
Copy link
Contributor

Adding X and Y Buttons as extra keys for L and R which is very handy for certain games specially fighting and fast paced action alike street fighter alpha 3 and sonic battle

Adding X and Y Buttons as extra keys for L and R which is very handy for certain games specially fighting and fast paced action alike street fighter alpha 3 and sonic battle
@andres-asm
Copy link
Contributor

You can alter the mapping with core input remapping. In any case this
should be an option not a default behavior

On Tue, Apr 19, 2016, 9:19 AM LodanZark notifications@github.com wrote:

Adding X and Y Buttons as extra keys for L and R which is very handy for
certain games specially fighting and fast paced action alike street fighter

alpha 3 and sonic battle

You can view, comment on, or merge this pull request online at:

#40
Commit Summary

  • Adding X and Y Buttons as extra keys for L and R

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#40

@LodanZark
Copy link
Contributor Author

LodanZark commented Apr 19, 2016

There is no issues or whatsoever, this change already happened in lr-gpsp and there is no negative reports neither complaints, it's important preserve the L and R buttons in their default mapping in situations that requires press L+A or R+B alike metroid games, and some games are better using the X Y instead R L because the buttons are closer, I am not removing the traditional mapping, I am giving more options and bring the best from both worlds specially since buttons X and Y are not being used, plus would be a mess adding core input remapping for each different game.

@inactive123
Copy link
Contributor

Alright, I dont see much wrong with this.

@inactive123 inactive123 merged commit 03c17ce into libretro:master Apr 19, 2016
@inactive123
Copy link
Contributor

Actually, thinking about it, it doesn't make much sense and having two conflicting L/R bound keys as input descriptors causes bad conflicts. So reverting this entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants