Fourier tempogram, PLP and friends #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcfee
added
enhancement
bmcfee
changed the title
|
Test issues are now fixed. I think this one's ready for CR. |
|
@stefan-balke any chance you could cr this? it's cool if not, just let me know. |
lostanlen
reviewed
Jun 21, 2019
Thanks! I'll clean those up and get it pushed. |
|
|
thanks for the CR!
bmcfee
changed the title
|
thanks @lostanlen and sry for not being responsive. Pretty busy these days... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Implements #739
What does this implement/fix? Explain your changes.
This PR implements predominant local pulse
beat.plp, Fourier tempogramfeature.fourier_tempogram, helper unit convertercore.fourier_tempo_frequenciesand axis decoration support for Fourier tempograms.Any other comments?
In implementing the unit tests for this, I discovered that the matplotlib image comparison tests were not executing properly (silently passing). I've fixed that here too, and in the process regenerated the baseline images.
I think this is basically good to go. I'm considering adding an advanced example notebook that shows how to use PLP with DP beat tracking, as done in section V.E of Grosche & Mueller 2011.