Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
N/A
What does this implement/fix? Explain your changes.
This adds a new parameter "gamma" to the constant-q filterbank creation (and by extension the calculation of filter lengths). "Gamma" allows us to lower the q-factor towards lower frequencies to a variable degree, while still maintaining an approximately constant q-factor at higher frequencies. Setting "gamma" equal to zero means that the filters created will be constant-q, and leaves the current functionality unchanged. The variable q-factor relaxes the need for large filters at low frequencies that the constant q-factor imposes.
See for more information:
Schörkhuber, Christian, et al. "A Matlab toolbox for efficient perfect reconstruction time-frequency transforms with log-frequency resolution." Audio Engineering Society Conference: 53rd International Conference: Semantic Audio. Audio Engineering Society, 2014.
Any other comments?
Forgive me if there is a better way to implement this (such as with separate functions), or if I have missed part of the process of making a contribution or anything required to make the change.