Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chroma and tonnetz updates #1183

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Chroma and tonnetz updates #1183

merged 4 commits into from
Jun 25, 2020

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented Jun 24, 2020

Reference Issue

Fixes #1170 (chroma-cqt resolution)
Fixes #1174 (tonnetz kwargs)

What does this implement/fix? Explain your changes.

This PR bundles fixes for two small issues:

  1. The default bins_per_octave for chroma_cqt is now 36 rather than 12
  2. tonnetz can now support pass-thru kwargs to chroma_cqt

Both of these are minute changes, so they're bundled here for convenience.

Any other comments?

The fixture for tonnetz plot testing has been updated.

@bmcfee bmcfee added enhancement Does this improve existing functionality? functionality Does this add new functionality? API change Does this change the behavior of existing API? labels Jun 24, 2020
@bmcfee bmcfee added this to the 0.8.0 milestone Jun 24, 2020
@bmcfee bmcfee requested a review from lostanlen June 24, 2020 18:48
@bmcfee bmcfee self-assigned this Jun 24, 2020
lostanlen
lostanlen approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@lostanlen lostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise 🙏

@bmcfee bmcfee merged commit 6f609e6 into main Jun 25, 2020
@bmcfee bmcfee deleted the chroma-tonnetz-updates branch June 25, 2020 13:08
@turian turian mentioned this pull request Jun 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostanlen lostanlen lostanlen approved these changes

Assignees

@bmcfee bmcfee

Labels
API change Does this change the behavior of existing API? enhancement Does this improve existing functionality? functionality Does this add new functionality?
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Why are features at STFT based upon n_fft and not fft_size? Change default bins_per_octave in chroma_cqt?
2 participants
@bmcfee @lostanlen